Internal shock or strut noise is uncommon. The most common cause for clunking noises over bumps is the mounts or attaching parts. Careful inspection is often required to identify the cause. Mountings and bushings can appear to be tight, but move slightly when driving. Viewing components when the suspension is hanging downward on a hoist may not reveal the cause. Replacing strut mounts is always recommended when replacing the struts. The insulating material density changes over time and the mount pivot bearings wear.
Other suspension and steering components often cause noises that the shocks/struts get blamed for: Ball joints, sway bar bushings & links are common causes.